Repository navigation
Cleanup example dependencies - #192
Merged
Merged
Conversation
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The broad runtime and lint-tool upgrades need compatibility validation beyond the reported example runs and overview type check.
0 open findings
What changed in this PR
Updates dependencies for the datastore examples and simplifies the overview example’s dependency declarations.
Changes:
- Raises both examples’ minimum
ni-datastoreversion to 2.1.0. - Removes redundant runtime and type-stub dependencies from the overview example.
- Refreshes the system example’s locked runtime and lint dependencies.
| File | Description |
|---|---|
| examples/system/pyproject.toml | Requires ni-datastore 2.1.0 or newer. |
| examples/system/poetry.lock | Updates resolved runtime and lint packages. |
| examples/overview/pyproject.toml | Upgrades datastore and removes unnecessary dependencies. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dixonjoel
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
ni.datastoredependency to 2.1.0 (latest released) for both examplesWhy should this Pull Request be merged?
Cleans up example dependencies and addresses at least one dependabot issue.
AB#4105402
What testing has been done?