Skip to content

feat: add possibility generate links for concrete rows#2828

Open
Koc wants to merge 3 commits into
mainfrom
feature/share-rows
Open

feat: add possibility generate links for concrete rows#2828
Koc wants to merge 3 commits into
mainfrom
feature/share-rows

Conversation

@Koc

@Koc Koc commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

This PR adds possibility to 1+ rows and generate link to them, like https://nextcloud.test/apps/tables/#/table/17?customFilters=%5B%5B%7B%22columnId%22%3A-1,%22operator%22%3A%22is-equal%22,%22value%22%3A%5B17197,17028,16446%5D%7D%5D%5D.

🎥 Demo

nextcloud-share-rows-2026-07-18_22.36.11.mp4

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stableX.X
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@Koc
Koc force-pushed the feature/share-rows branch from f53c3fb to 00a3f25 Compare July 18, 2026 20:35
@Koc
Koc marked this pull request as ready for review July 18, 2026 20:43
@Koc
Koc requested review from blizzz and enjeck as code owners July 18, 2026 20:43
path: this.$route.path,
query: {
...this.$route.query,
customFilters: JSON.stringify([[

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I don't like that we're sending potentially large json string to the server as a query parameter. Any better ideas for that?

a. use POST + body
b. use QUERY + body
c. ...?

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very cool and reminds me of #662, which i had attempted to implement at some point and stopped. Let me think about if that is applicable here, maybe this idea of generating links should be more extensible somehow...

@enjeck enjeck added the 3. to review Waiting for reviews label Jul 23, 2026
Koc added 3 commits July 23, 2026 23:33
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc
Koc force-pushed the feature/share-rows branch from 48edcea to c623e17 Compare July 23, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants