Skip to content

Fix scroll on embedded widget and adjust height to screen size#2808

Open
taiebot wants to merge 2 commits into
nextcloud:mainfrom
taiebot:Embed-scroll
Open

Fix scroll on embedded widget and adjust height to screen size#2808
taiebot wants to merge 2 commits into
nextcloud:mainfrom
taiebot:Embed-scroll

Conversation

@taiebot

@taiebot taiebot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🖼️ Screenshots

Fix #2596 another solution to #2744

This has been tested on multiple scenarios.
With ClaudeAI i have done multiple tests cases and this is the solution i came up with.

The table widget embedded in Nextcloud Text/Collectives had several visual bugs when scrolling and missed the three dots to manage the widget. After this PR the widget renders properly.

Interactive cells (star ratings, URLs, richtext editors) scrolled over the sticky header (title + search bar) instead of passing underneath it
The widget had a fixed height of 50vh with no adaptation to screen size
On iOS/iPad, the widget scroll captured the entire page scroll

🏚️ On main 🏡 With PR
image image

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stableX.X
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

What is still broken on embedded table and not part of this pr

  • column ordering do not respect table
  • sort is not even plugged in

Signed-off-by: taiebot <dedreuil@yahoo.fr>
@taiebot
taiebot requested review from blizzz and enjeck as code owners July 7, 2026 20:58
@taiebot taiebot changed the title Fix scroll on embedded widget and adjust height to page Fix scroll on embedded widget and adjust height to screen size Jul 7, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Could you please confirm whether you manually tested this with:

  • an embedded table where row actions are visible, so the right-side action column also scrolls away instead of staying sticky
  • a wide table with horizontal scrolling

I’m especially wondering about the action column, since it still receives sticky styling from the shared table component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Embedded tables some column overflow on header

2 participants