Fix scroll on embedded widget and adjust height to screen size#2808
Fix scroll on embedded widget and adjust height to screen size#2808taiebot wants to merge 2 commits into
Conversation
Signed-off-by: taiebot <dedreuil@yahoo.fr>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
enjeck
left a comment
There was a problem hiding this comment.
Thanks for the fix. Could you please confirm whether you manually tested this with:
- an embedded table where row actions are visible, so the right-side action column also scrolls away instead of staying sticky
- a wide table with horizontal scrolling
I’m especially wondering about the action column, since it still receives sticky styling from the shared table component.
🖼️ Screenshots
Fix #2596 another solution to #2744
This has been tested on multiple scenarios.
With ClaudeAI i have done multiple tests cases and this is the solution i came up with.
The table widget embedded in Nextcloud Text/Collectives had several visual bugs when scrolling and missed the three dots to manage the widget. After this PR the widget renders properly.
Interactive cells (star ratings, URLs, richtext editors) scrolled over the sticky header (title + search bar) instead of passing underneath it
The widget had a fixed height of 50vh with no adaptation to screen size
On iOS/iPad, the widget scroll captured the entire page scroll
🏁 Checklist
/backport to stableX.X🤖 AI (if applicable)
What is still broken on embedded table and not part of this pr