feat(federation): Federated table sharing by benjaminfrueh · Pull Request #2786 · nextcloud/tables

benjaminfrueh · 2026-07-03T14:38:59Z

Federated table sharing

Allows sharing tables with users on other Nextcloud instances.

Todo

🏁 Checklist

⛑️ Tests (unit and/or integration) are included or not needed
🔙 Backport requests are created or not needed: /backport to stableX.X
📅 Milestone is set
🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

The content of this PR was partly or fully generated using AI

grnd-alt

Did not entirely check all code paths yet. But the general structure looks good 🔥

What I noticed though: when creating a federated share it instantly shows as a new table on the receiving user's view. In Deck I think we're sending a notification that the user has to confirm before it shows in the app, so user's don't get spammed.

benjaminfrueh · 2026-07-17T08:07:33Z

Did not entirely check all code paths yet. But the general structure looks good 🔥

What I noticed though: when creating a federated share it instantly shows as a new table on the receiving user's view. In Deck I think we're sending a notification that the user has to confirm before it shows in the app, so user's don't get spammed.

Thanks for the feedback! After checking Deck's shareReceived(), it also seems to insert the board immediately and just sends an informational notification without accept/decline flow.
An "Pending shares" acceptance flow, similar to how Files handles federated shares would maybe be a good addition to both deck and tables federated sharing - maybe we can consider it as a follow-up feature?

Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>

blizzz · 2026-07-22T18:39:31Z

 namespace OCA\Tables\AppInfo;

 use Exception;
+use OC\OCM\OCMSignatoryManager;


Would be cool (and more sustainable) when there will be a public interface for this, but definitely out of scope for now, might be accompanied by an issue against server if there is not one yet.

(On second look it might be more complicated than that)

blizzz

some things that would be good to have, but no definite blocker by reading the code

blizzz · 2026-07-22T18:44:41Z

+		if ($this->federationService->isNodeFederated($tableId, 'table')) {
+			$table = $this->tableService->find($tableId, true);
+			return new DataResponse($this->federationService->getColumns($table));
+		}


Smells a bit as if it wants to be in the try-block, too.

blizzz · 2026-07-22T18:44:58Z

+		if ($this->federationService->isNodeFederated($viewId, 'view')) {
+			$view = $this->viewService->find($viewId, true);
+			return new DataResponse($this->federationService->getColumns($view));
+		}


blizzz · 2026-07-22T18:50:08Z

+		if ($this->federationService->isNodeFederated($tableId, 'table')) {
+			$table = $this->tableService->find($tableId, true);
+			return new DataResponse($this->federationService->getRows($table));
+		}


and this might want to be within the handleError() callback?

blizzz · 2026-07-22T18:50:17Z

 	public function presentInView(int $id, int $viewId): DataResponse {
+		if ($this->federationService->isNodeFederated($viewId, 'view')) {
+			return new DataResponse(['present' => true]);
+		}


blizzz · 2026-07-22T18:55:25Z

+	#[RequirePermission(permission: Application::PERMISSION_UPDATE, typeParam: 'nodeCollection')]
+	#[ApiRoute(verb: 'PUT', url: '/api/2/{nodeCollection}/{nodeId}/rows/{rowId}', requirements: ['nodeCollection' => '(tables|views)', 'nodeId' => '(\d+)'])]
+	public function updateRow(string $nodeCollection, int $nodeId, int $rowId, mixed $data): DataResponse {
+		if (is_string($data)) {


$data could be of type string|array then?

blizzz · 2026-07-22T19:42:40Z

+use OCP\Migration\IOutput;
+use OCP\Migration\SimpleMigrationStep;
+
+class Version002003Date20260630000000 extends SimpleMigrationStep {


afraid this is sorted not at latest and might not run, but i might be wrong

blizzz · 2026-07-22T19:53:46Z

+	}
+
+	public function notifyPermissionUpdate(Share $share): void {
+		$this->proxy->sendNotification(


what if any of those requests do not get through (maybe the remote nextcloud is being updated), will they be retried?

blizzz · 2026-07-22T20:01:45Z

 				<referencedClass name="Doctrine\DBAL\Types\Types" />
 				<referencedClass name="OC\Core\Command\Base" />
+				<referencedClass name="OC\Http\Client\Response" />
+				<referencedClass name="OC\OCM\OCMSignatoryManager" />


stub would be preferred

blizzz · 2026-07-22T20:02:04Z

 				<referencedClass name="Doctrine\DBAL\Schema\Table" />
 				<referencedClass name="Doctrine\DBAL\Types\Types" />
 				<referencedClass name="OC\Core\Command\Base" />
+				<referencedClass name="OC\Http\Client\Response" />


this should have an interface?

blizzz · 2026-07-22T20:16:16Z

+			$body->rewind();
+
+			if (!is_array(json_decode($content, true))) {
+				throw new \Exception('Error parsing JSON response', $status);


Here and and other places, throwing a generic \Exception is broad, and so would be catching them.

blizzz · 2026-07-22T20:18:39Z

 	#[CORS]
 	#[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
 	public function indexTableColumns(int $tableId, ?int $viewId): DataResponse {
+		if ($this->federationService->isNodeFederated($tableId, 'table')) {


and this actually throws when federation is disabled

same in the method below
and in RowController
and in the places in the RowOCSController

Signed-off-by: samin-z <samin.zavarkesh@gmail.com>

benjaminfrueh requested review from blizzz and enjeck as code owners July 3, 2026 14:39

benjaminfrueh marked this pull request as draft July 3, 2026 14:40

benjaminfrueh requested a review from grnd-alt July 3, 2026 14:41

benjaminfrueh changed the title ~~feat(federation): schema, outgoing share and frontend support~~ feat(federation): Federated Table Sharing Jul 3, 2026

benjaminfrueh changed the title ~~feat(federation): Federated Table Sharing~~ feat(federation): Federated table sharing Jul 3, 2026

AndyScherzinger added enhancement New feature or request 2. developing Work in progress labels Jul 3, 2026

benjaminfrueh added this to 📝 Productivity team Jul 3, 2026

github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Jul 3, 2026

benjaminfrueh moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Productivity team Jul 3, 2026

benjaminfrueh force-pushed the feat/federated-sharing branch 7 times, most recently from 403289e to ba97e23 Compare July 8, 2026 07:13

grnd-alt reviewed Jul 9, 2026

View reviewed changes

Comment thread lib/Controller/FederationColumnOCSController.php Outdated

benjaminfrueh force-pushed the feat/federated-sharing branch from 4da0386 to 35b4e5e Compare July 13, 2026 16:28

benjaminfrueh marked this pull request as ready for review July 14, 2026 14:33

benjaminfrueh force-pushed the feat/federated-sharing branch 2 times, most recently from 1bf2714 to e948b30 Compare July 14, 2026 14:46

benjaminfrueh added this to the v2.3.0 milestone Jul 14, 2026

benjaminfrueh force-pushed the feat/federated-sharing branch 5 times, most recently from 8a02508 to 63c7628 Compare July 16, 2026 08:50

nextcloud-command added the AI assisted label Jul 16, 2026

benjaminfrueh force-pushed the feat/federated-sharing branch from 63c7628 to c66887c Compare July 16, 2026 12:38

grnd-alt requested changes Jul 16, 2026

View reviewed changes

benjaminfrueh force-pushed the feat/federated-sharing branch 7 times, most recently from 5be9580 to 4beef8f Compare July 17, 2026 07:57

benjaminfrueh force-pushed the feat/federated-sharing branch from 4beef8f to a38af3d Compare July 17, 2026 14:10

benjaminfrueh requested a review from grnd-alt July 17, 2026 14:11

feat(federation): federated table and view sharing

e6485cc

Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>

blizzz force-pushed the feat/federated-sharing branch from a38af3d to e6485cc Compare July 22, 2026 18:30

blizzz reviewed Jul 22, 2026

View reviewed changes

Comment thread lib/Federation/FederationProxy.php

blizzz reviewed Jul 22, 2026

View reviewed changes

blizzz requested changes Jul 22, 2026

View reviewed changes

fix: when federation is disabled, local table APIs dont fail

17607a6

Signed-off-by: samin-z <samin.zavarkesh@gmail.com>

Uh oh!

Conversation

benjaminfrueh commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Federated table sharing

Todo

🏁 Checklist

🤖 AI (if applicable)

Uh oh!

Uh oh!

grnd-alt left a comment

Choose a reason for hiding this comment

Uh oh!

benjaminfrueh commented Jul 17, 2026

Uh oh!

blizzz Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blizzz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blizzz Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

benjaminfrueh commented Jul 3, 2026 •

edited

Loading

blizzz Jul 22, 2026 •

edited

Loading

blizzz Jul 22, 2026 •

edited

Loading