feat: add relation lookup column type#2271
Open
Koc wants to merge 2 commits into
Open
Conversation
Koc
force-pushed
the
feature/add-lookup-column-type
branch
3 times, most recently
from
January 19, 2026 17:46
abbdf56 to
30a0005
Compare
Koc
force-pushed
the
feature/add-relations-column-type
branch
2 times, most recently
from
January 25, 2026 12:47
f34f8f9 to
d406233
Compare
Koc
force-pushed
the
feature/add-relations-column-type
branch
5 times, most recently
from
February 15, 2026 16:40
502b69b to
8093d63
Compare
Koc
force-pushed
the
feature/add-relations-column-type
branch
7 times, most recently
from
February 28, 2026 18:32
d45b95c to
cb637bd
Compare
enjeck
force-pushed
the
feature/add-relations-column-type
branch
from
March 4, 2026 04:59
cb637bd to
9b36f43
Compare
Koc
force-pushed
the
feature/add-relations-column-type
branch
3 times, most recently
from
March 25, 2026 23:07
b47617a to
3240639
Compare
enjeck
force-pushed
the
feature/add-relations-column-type
branch
from
April 23, 2026 03:47
3240639 to
0cdfefa
Compare
Koc
force-pushed
the
feature/add-relations-column-type
branch
3 times, most recently
from
May 4, 2026 21:45
b707106 to
f3c29d8
Compare
Koc
force-pushed
the
feature/add-relations-column-type
branch
from
May 7, 2026 14:05
f3c29d8 to
b426237
Compare
Koc
marked this pull request as ready for review
July 12, 2026 00:31
Koc
force-pushed
the
feature/add-lookup-column-type
branch
from
July 12, 2026 00:31
87248d9 to
fd0695d
Compare
Koc
force-pushed
the
feature/add-lookup-column-type
branch
9 times, most recently
from
July 15, 2026 22:58
a94d637 to
ac1036d
Compare
5 tasks
Koc
changed the title
Open
enjeck
reviewed
Jul 20, 2026
enjeck
left a comment
enjeck
left a comment
Contributor
There was a problem hiding this comment.
Even with the screenshots, I'm not sure what we're adding and what the usecase is?
Contributor
Author
|
@enjeck I've updated description:
|
Koc
commented
Jul 23, 2026
Koc
commented
Jul 23, 2026
Comment on lines
+66
to
+71
| if (column.type === ColumnTypes.RelationLookup) { | ||
| rowData[column.title] = this.getRelationLookupValue(column, row, dataStore) | ||
| } else { | ||
| const set = row.data ? row.data.find(d => d.columnId === column.id) || '' : null | ||
| rowData[column.title] = set ? column.getValueString(set) : '' | ||
| } |
Contributor
Author
There was a problem hiding this comment.
try to omit if/else and move functionality to the column class
Koc
force-pushed
the
feature/add-lookup-column-type
branch
3 times, most recently
from
July 25, 2026 13:22
8865ddc to
e3d186a
Compare
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/add-lookup-column-type
branch
from
July 25, 2026 13:43
e3d186a to
dd0bdd6
Compare
Contributor
Author
|
added Behat tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is continuation of #2248 that allows to display more column from relation table.
There are 2 tables:
employeesandvacations. We can addvacation.requesterrelation column that referenced to the row id of theemployeeand displayemployee.name. But what if we need to display more column from the related table? e.g.employee.department. That's where relation lookup can help: select already existent relation and choose what extra column should be displayed.🖼️ Screenshots
🗒️ TODO