fix: improve type hinting for unified share listing methods - #62989
Merged
Conversation
icewind1991
requested review from
CarlSchwan,
leftybournes,
nfebe,
salmart-dev and
sorbaugh
and removed request for
a team
August 6, 2026 20:56
susnux
approved these changes
Aug 6, 2026
CarlSchwan
approved these changes
Aug 7, 2026
CarlSchwan
enabled auto-merge
August 7, 2026 06:10
CarlSchwan
force-pushed
the
unified-sharing-list-type-hints
branch
from
August 7, 2026 06:11
7225b2c to
e9d0f71
Compare
icewind1991
force-pushed
the
unified-sharing-list-type-hints
branch
from
August 7, 2026 15:49
e9d0f71 to
50f7538
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
unified-sharing-list-type-hints
branch
from
August 7, 2026 16:56
50f7538 to
995ac97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minor improvements to type hints and improved parameter checking in controller.
Checklist
3. to review, feature component)stable32)AI (if applicable)