[stable34] fix(share): Avoid crash when share owner is not found - #62798
Open
backportbot[bot] wants to merge 1 commit into
Open
[stable34] fix(share): Avoid crash when share owner is not found#62798backportbot[bot] wants to merge 1 commit into
backportbot[bot] wants to merge 1 commit into
Conversation
backportbot
Bot
requested review from
Altahrim,
come-nc,
icewind1991,
nfebe and
sorbaugh
and removed request for
a team
August 3, 2026 16:13
IShare::getNode is documented to throw only NotFoundException, so catch UserNotFoundException from the level below and wrap it. This avoids crashes from share api controller when listing shares and one of them is broken because its owner has vanished from the backend. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
backport/62791/stable34
branch
from
August 3, 2026 16:21
28beadc to
b05a456
Compare
come-nc
approved these changes
Aug 3, 2026
come-nc
left a comment
come-nc
left a comment
Contributor
There was a problem hiding this comment.
Adapted to 34. Should backport this version to older releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #62791