fix(apps): filter autoloading registration by app type in loadApps#59679
Open
joshtrichards wants to merge 1 commit intomasterfrom
Open
fix(apps): filter autoloading registration by app type in loadApps#59679joshtrichards wants to merge 1 commit intomasterfrom
joshtrichards wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
loadApps(array $types = [])apply the$typesfilter consistently to both code paths.Previously, the initial autoloader-registration loop ignored
$typesand touched all enabled apps, while the laterloadApp()loop only loaded matching app types. SinceloadApp()already handles autoloader registration itself, this broad pre-registration was inconsistent with the method contract and appears redundant for filtered loads. PHP CI also passed with the$typesfilter applied.Context
I couldn’t find evidence that
loadApps()must pre-register autoloaders for non-target app types;loadApp()andCoordinatoralready register autoloading per app. At best, this looks like historical baggage rather than part of the documented contract.To stay conservative in case there are hidden cross-app assumptions (that aren't already addressed in other ways), this change only applies the
$typesfilter to the first loop for now, rather than removing that loop entirely.Testing
$typesfilter applied to the autoloader-registration loop.Notes
IBootstrapand non-IBootstrapapps.Checklist
3. to review, feature component)stable32)AI (if applicable)