refactor(psalm): Fully type IStorageFactory#58463
Open
CarlSchwan wants to merge 1 commit intomasterfrom
Open
Conversation
8e859ec to
623b249
Compare
provokateurin
requested changes
Feb 23, 2026
Member
provokateurin
left a comment
There was a problem hiding this comment.
Please add all files to psalm:strict and rector:strict.
Signed-off-by: Carl Schwan <carlschwan@kde.org>
623b249 to
7db5646
Compare
Member
Author
psalm strict really disliked the usort call for some reasons |
Member
|
That's odd, I can take a look tomorrow if you want me to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)