Skip to content

[stable33] fix: generate favourite icon without imagick svg support - #58225

Open
backportbot[bot] wants to merge 1 commit into
stable33from
backport/55132/stable33
Open

[stable33] fix: generate favourite icon without imagick svg support#58225
backportbot[bot] wants to merge 1 commit into
stable33from
backport/55132/stable33

Conversation

@backportbot

@backportbot backportbot Bot commented Feb 10, 2026

Copy link
Copy Markdown

Backport of PR #55132

@backportbot
backportbot Bot requested review from a team and provokateurin as code owners February 10, 2026 15:19
@backportbot
backportbot Bot requested review from Altahrim, ArtificialOwl, ChristophWurst, SebastianKrupinski, come-nc and salmart-dev and removed request for a team February 10, 2026 15:19
@backportbot backportbot Bot added bug 3. to review Waiting for reviews labels Feb 10, 2026
@backportbot backportbot Bot added this to the Nextcloud 33 milestone Feb 10, 2026
@SebastianKrupinski
SebastianKrupinski marked this pull request as draft February 10, 2026 15:19
@SebastianKrupinski
SebastianKrupinski marked this pull request as ready for review February 13, 2026 15:09
Comment on lines +147 to +149
$resX = (int)(72 * $size / $x);
$resY = (int)(72 * $size / $y);
$appIconFile->setResolution($resX, $resY);

@come-nc come-nc Feb 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are reverting the fix I did in #57653
Please fix that in this backport and on master as well.

@SebastianKrupinski

Copy link
Copy Markdown
Contributor

This will require this:

#58526

Then this:

#60234

@SebastianKrupinski

Copy link
Copy Markdown
Contributor

@ChristophWurst

Force please

@SebastianKrupinski SebastianKrupinski added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 14, 2026
@AndyScherzinger

Copy link
Copy Markdown
Member

@SebastianKrupinski in #58225 (comment) you state it needs

This will require this:

#58526

Then this:

#60234

While #58526 is merged, #60234 is still in draft state (!)

@SebastianKrupinski

Copy link
Copy Markdown
Contributor

While #58526 is merged

  • this is only merged in master which was 34, the back port for 33 was never triggered because this PR needs to be merged first.

#60234 is still in draft state (!)

@SebastianKrupinski
SebastianKrupinski force-pushed the backport/55132/stable33 branch 2 times, most recently from 4f44544 to eebab2d Compare July 30, 2026 12:34
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants