Account menu tweaks - #13633
Open
kesselb wants to merge 4 commits into
Open
Conversation
kesselb
requested review from
hamza221
and removed request for
ChristophWurst and
GretaD
September 3, 2026 19:11
madbob
approved these changes
Sep 3, 2026
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Fixes an issue introduced by #13510. The account settings component is no longer destroyed, its content is swapped instead, so all sections share one dialog registry. They were unkeyed siblings of the same component type and Vue matched them positionally, so a shift of the filters section could re-register an id before its previous holder released it, throwing "Duplicate section id found: quick-actions-settings". Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
account-menu-tweaks
branch
from
September 3, 2026 19:27
e1755cd to
36b7809
Compare
Collaborator
|
Tested, working and approved. A side consideration I made some time ago (non blocking for this PR): the Sieve editor is a bit too... visible. Most of users are not able to manually write Sieve rules, yet putting an (apparently harmless) text editor in front of them may lead to unintented edits (and breakings). Maybe "hiding" it in a modal, accessible through an "Advanced settings" button (where "Advanced" is used as a deterrent), may keep the casual user a step further away from disaster. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change 1: Move folder search below calendar and classification settings. I think it fit's there much better.
Change 2: Move sieve script editor below sieve server. It takes a lot of space in the current version and is usually not required for your day work.
Change 3: Show the filter's component even with sieve disabled. Like autoresponder it gets a small hint to enable sieve. Now using a NcNoteCard.
Change 4: Add the key for each component. That resolves an issue that was introduced by #13510 because the account component is not destroyed anymore.
馃 AI (if applicable)