Skip to content

refactor: drop exact from envelope and envelopeskeleton - #13625

Open
GretaD wants to merge 1 commit into
mainfrom
refactor/drop-exact
Open

refactor: drop exact from envelope and envelopeskeleton#13625
GretaD wants to merge 1 commit into
mainfrom
refactor/drop-exact

Conversation

@GretaD

@GretaD GretaD commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

ref: #13622

Vue Router 4 matches routes exactly by default, making the exact
prop a no-op. Dropped the binding in Envelope.vue and the prop
declaration + template binding in EnvelopeSkeleton.vue.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Summary by CodeRabbit

  • Bug Fixes
    • Updated envelope list navigation so items remain active when viewing related nested routes.
    • Removed exact route matching from envelope skeleton links.

Signed-off-by: greta <gretadoci@gmail.com>
@GretaD
GretaD requested a review from GVodyanov September 2, 2026 14:29
@GretaD GretaD self-assigned this Sep 2, 2026
@ChristophWurst

Copy link
Copy Markdown
Member

And that is compatible with the current router too?

@ChristophWurst

Copy link
Copy Markdown
Member

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The envelope components no longer use exact route matching. Envelope.vue stops passing the option, and EnvelopeSkeleton.vue stops binding it to router-link.

Changes

Envelope route matching

Layer / File(s) Summary
Remove exact route matching
src/components/Envelope.vue, src/components/EnvelopeSkeleton.vue
The envelope link now receives only its destination route. The exact route-matching binding was removed from both component usage and the router-link wrapper.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: 🔵 Low · up to b05da

Removing exact route matching may cause the wrong envelope to appear selected when a message route includes a draft identifier. This is a bounded UI correctness risk; the PR is otherwise mergeable with explicit owner awareness or follow-up.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the exact behavior from Envelope and EnvelopeSkeleton.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/drop-exact

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: faf7dcc4-503b-4348-8c23-1a02e832a215

📥 Commits

Reviewing files that changed from the base of the PR and between a83e908 and b05da80.

📒 Files selected for processing (2)
  • src/components/Envelope.vue
  • src/components/EnvelopeSkeleton.vue
💤 Files with no reviewable changes (1)
  • src/components/Envelope.vue

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Comment thread src/components/EnvelopeSkeleton.vue
@GretaD GretaD mentioned this pull request Sep 3, 2026
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants