fix(autocomplete): respect privacy settings for sharing#12715
Open
fix(autocomplete): respect privacy settings for sharing#12715
Conversation
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
hamza221
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
ChristophWurst
requested changes
Apr 14, 2026
| @@ -262,14 +281,14 @@ private function doSearch(string $term, array $fields, bool $strictSearch) : arr | |||
| * @param string $mailAddr | |||
Member
There was a problem hiding this comment.
now phpdoc is out of sync. either have both params or preferrably drop both if there is no additional info
Comment on lines
+59
to
+61
| ->with('', $fn) | ||
| ->willReturn($contacts); | ||
| $result = $this->service->run($fn, $email); | ||
| $result = $this->service->run('', $fn, $email); |
Member
There was a problem hiding this comment.
can you make this meaningful?
| ]); | ||
|
|
||
| $result = $this->check->run('Sender Name', 'sender@example.com'); | ||
| $result = $this->check->run('', 'Sender Name', 'sender@example.com'); |
| ]; | ||
|
|
||
| $actual = $this->contactsIntegration->getContactsWithName($name); | ||
| $actual = $this->contactsIntegration->getContactsWithName('', $name); |
Contributor
Author
|
@ChristophWurst I've been actually wondering if we want to always allow full sab access to phishing detection check? maybe without exposing the actual contact ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to test:
@the mention shortcut in composerrespect them