Add MultimodalChatWithToolsProvider#400
Open
lukasdotcom wants to merge 7 commits into
Open
Conversation
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
lukasdotcom
force-pushed
the
multimodal-provider
branch
from
July 8, 2026 19:11
852adf4 to
9254c32
Compare
…on for older providers Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
lukasdotcom
force-pushed
the
multimodal-provider
branch
from
July 9, 2026 20:29
9254c32 to
60ee11d
Compare
1 task
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
lukasdotcom
marked this pull request as ready for review
July 14, 2026 16:56
…context agent Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
lukasdotcom
force-pushed
the
multimodal-provider
branch
from
July 15, 2026 20:11
bb8863b to
1808448
Compare
marcelklehr
reviewed
Jul 16, 2026
marcelklehr
reviewed
Jul 16, 2026
| $content = []; | ||
| foreach ($message['content'] as $item) { | ||
| if ($item['type'] === 'file') { | ||
| $content = array_merge($content, $this->openAiFileService->buildFileContentFromId($item['file_id'], $userId, $item['ocp_task_id'] ?? null)); |
Member
Author
There was a problem hiding this comment.
Not sure how to handle it for the fileId only path, but if it is from a task the getUserTask accepts a null value for userId.
marcelklehr
reviewed
Jul 16, 2026
| throw new ProcessingException('File is not readable'); | ||
| } | ||
| // Maximum file size for openai is 50MB. | ||
| if ($this->isUsingOpenAi() && $file->getSize() > self::MAX_FILE_SIZE_BYTES) { |
Member
There was a problem hiding this comment.
Should we add a file size limit fro the general case as well?
Member
Author
There was a problem hiding this comment.
I can do the exact same limit as for openai unless you think a different one is better.
marcelklehr
reviewed
Jul 16, 2026
| $unset = '__unset__'; | ||
| $newValue = $this->appConfig->getValueString(Application::APP_ID, 'multimodal_image_enabled', $unset); | ||
| if ($newValue !== $unset) { | ||
| return; |
Member
There was a problem hiding this comment.
This shifts the default state from 0 to 1, I think. Ideally, if it has been unset previously, we should set it to what used to be the default.
Member
Author
There was a problem hiding this comment.
Back when analyze image was created I don't think IONOS had a model with support for image input, but now that they do I think it might be worth it to change the default to on instead of off.
marcelklehr
reviewed
Jul 16, 2026
lukasdotcom
force-pushed
the
multimodal-provider
branch
from
July 16, 2026 12:44
d6a95cb to
87ec6d9
Compare
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
lukasdotcom
force-pushed
the
multimodal-provider
branch
from
July 16, 2026 12:44
87ec6d9 to
1902b7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds multimodal chat and also switches to enable also settings to enable different kinds of attachments. The new multimodal settings are also used for audio2audio chat and analyze image.
Look at nextcloud/assistant#602 to see all relevant pr's for this
🤖 AI (if applicable)