Repository navigation
Add support for redis user enviroment variable - #892
Open
jholmes802 wants to merge 2 commits into
Open
jholmes802 wants to merge 2 commits into
jholmes802 wants to merge 2 commits into
Conversation
wrenix
reviewed
Oct 20, 2026
| @@ -212,14 +212,18 @@ Redis env vars | |||
| value: {{ .Values.externalRedis.password | quote }} | |||
| {{- end }} | |||
| {{- end }}{{/* end-of redis-enabled*/}} | |||
Author
There was a problem hiding this comment.
@wrenix I am not seeing an issues with the end. Are you suggesting this should be in the redis.auth.enabled section with the rest of those settings?
wrenix
reviewed
Oct 20, 2026
| | `nextcloud.mail.smtp.port` | Optional SMTP port | `nil` | | ||
| | `nextcloud.mail.smtp.authtype` | SMTP authentication method | `LOGIN` | | ||
| | `nextcloud.mail.smtp.name` | SMTP username, ONLY the part before the domain name. i.e. 'postmaster' NOT 'postmaster@example.com' | `''` | | ||
| | `nextcloud.mail.smtp.name` | SMTP username, ONLY the part before the domain name. i.e. 'postmaster' NOT '<postmaster@example.com>' | `''` | |
Author
There was a problem hiding this comment.
My bad, I was moving quickly and didn't notice it get caught in my auto formater. Sorry about that. Undoing as I speak
wrenix
reviewed
Oct 20, 2026
wrenix
reviewed
Oct 20, 2026
| auth: | ||
| enabled: true | ||
| # Username for redis authentication | ||
| # user: "default" |
Collaborator
There was a problem hiding this comment.
please do not comment value-fields out ... make them nil instatt.
Suggested change
| # user: "default" | |
| user: |
wrenix
requested changes
Oct 20, 2026
jholmes802
force-pushed
the
redis-user
branch
from
October 22, 2026 02:13
eb9d567 to
604ba8b
Compare
wrenix
reviewed
Oct 23, 2026
| value: {{ .Values.externalRedis.password | quote }} | ||
| {{- end }} | ||
| {{- end }}{{/* end-of redis-enabled*/}} | ||
| {{- if .Values.redis.auth.user }} |
Collaborator
There was a problem hiding this comment.
Suggested change
| {{- if .Values.redis.auth.user }} | |
| {{- with .Values.redis.auth.user }} | |
| .... | |
| value: {{ quote . }} |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This change adds a native value spec for the username a redis account may need.
Currently the only way to do this is with an "extraEnv" section, but it doesn't update the REDIS_URL environment variable.
This change focuses on adding an example to the values.yaml doc, and the helpers which generates the environment variables.
Benefits
Adds native support for a redis user other than the default.
Possible drawbacks
Can't think of any at the time.
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.