Skip to content

feat: optimize member list#5330

Open
Koc wants to merge 1 commit into
mainfrom
feature/optimize-members-list
Open

feat: optimize member list#5330
Koc wants to merge 1 commit into
mainfrom
feature/optimize-members-list

Conversation

@Koc
Copy link
Copy Markdown

@Koc Koc commented May 18, 2026

This PR speedups loading of the members list for a circle especially for the federated users.

🗒️ Changes

  • load only first 101 members and display them using virtual list with note that there are more results
    • there is possibility to load all members
  • added filter by username and role
    • including "pending" role
  • silently reload members list on user role change

🖼️ Screenshoot

image

🎥 Demo

nextcloud-contacts-2-2026-05-29_01.04.11.mp4

Depends on nextcloud/circles#2482

@Koc Koc force-pushed the feature/optimize-members-list branch from 4816864 to 821523c Compare May 18, 2026 16:21
@Koc Koc changed the title feat: optimize members list feat: optimize member list May 18, 2026
@Koc Koc force-pushed the feature/optimize-members-list branch 2 times, most recently from 6f5a603 to 27bb7be Compare May 18, 2026 16:23
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 0% with 136 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/MemberList/MemberList.vue 0.00% 112 Missing ⚠️
src/components/MemberList/MemberListGroup.vue 0.00% 16 Missing ⚠️
src/store/circles.js 0.00% 6 Missing and 1 partial ⚠️
src/components/MemberList/MemberGridItem.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Koc Koc force-pushed the feature/optimize-members-list branch from 27bb7be to aab4d2a Compare May 18, 2026 21:38
@Koc Koc force-pushed the feature/optimize-members-list branch 4 times, most recently from 72fc93e to f7beffd Compare May 28, 2026 22:17
@Koc Koc force-pushed the feature/optimize-members-list branch from f7beffd to ae6ab32 Compare May 28, 2026 22:31
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc Koc force-pushed the feature/optimize-members-list branch from ae6ab32 to cc59585 Compare May 28, 2026 22:47
@Koc Koc marked this pull request as ready for review May 28, 2026 23:06
@Koc Koc requested review from GVodyanov and hamza221 as code owners May 28, 2026 23:06
@Koc Koc requested a review from Copilot May 28, 2026 23:07
@Koc Koc requested a review from mejo- May 28, 2026 23:08
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants