chore: re-sync appstore-build-publish workflow with org template (Node 20)#5328
Open
brdns wants to merge 1 commit into
Open
chore: re-sync appstore-build-publish workflow with org template (Node 20)#5328brdns wants to merge 1 commit into
brdns wants to merge 1 commit into
Conversation
Bumps the 5 following GitHub actions up to the versions currently in used at nextcloud/.github/workflow-templates/appstore-build-publish.yml, to address the Node.js 20 deprecation warning by GitHub which should be effective quite soon (2026-06-02): actions/setup-node v6.2.0 -> v6.4.0 andstor/file-existence-action v3.0.0 -> v3.1.0 icewind1991/nextcloud-version-matrix v1.3.1 -> v1.3.2 shivammathur/setup-php 2.36.0 -> 2.37.0 skjnldsv/xpath-action master -> v1.0.0 Two GitHub actions remain on Node 20 because they actually don't avec a more recent release: skjnldsv/check-actor-permission (v3.0 2024) skjnldsv/read-package-engines-version-actions (v3 2024) These should get a separate upstream release which is out of scope here. Signed-off-by: brdns <101930208+brdns@users.noreply.github.com>
brdns
requested review from
GVodyanov,
SebastianKrupinski and
hamza221
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
The
appstore-build-publishworkflow run for v8.4.6 brings two deprecation warnings onubuntu-latest:set-outputcommand was deprecated in 2022.nextcloud/.github/workflow-templates/appstore-build-publish.ymlalready pins newer versions that address 5 of the 7 listed GitHub actions. This PR re-syncsnextcloud/contactswith the upstream Nextcloud template.Edits
5 bumps in
.github/workflows/appstore-build-publish.yml:actions/setup-nodeandstor/file-existence-actionicewind1991/nextcloud-version-matrixshivammathur/setup-phpskjnldsv/xpath-action@masterStill needs attention
Two actions stay on Node 20 because they have no newer release:
skjnldsv/check-actor-permission: last tag v3.0 (2024-02)skjnldsv/read-package-engines-version-actions: last tag v3 (2024-02)