Skip to content

fix(contacts): handle line manager property creation#5304

Merged
hamza221 merged 1 commit into
nextcloud:stable8.3from
nfk:fix/line-manager-property
May 21, 2026
Merged

fix(contacts): handle line manager property creation#5304
hamza221 merged 1 commit into
nextcloud:stable8.3from
nfk:fix/line-manager-property

Conversation

@nfk
Copy link
Copy Markdown

@nfk nfk commented May 7, 2026

Adding the Line manager field created an empty x-managersname property and then immediately tried to focus the newly rendered editor. When the property had no matching contact value, the select received an undefined value and no focusable field was available.

This produced the following JavaScript errors:

  • No focusable element found for property x-managersname
  • TypeError: can't access property "toLowerCase", this.localValue is undefined

Keep empty manager properties represented as an empty string, guard select matching before lowercasing the local value, and store the only available manager using the vCard display name plus UID parameter instead of the internal contact key.

Fixes #4454

@nfk nfk requested review from GVodyanov and hamza221 as code owners May 7, 2026 09:05
@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews feature: contacts labels May 7, 2026
Comment thread src/components/ContactDetails/ContactDetailsAddNewProp.vue
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...onents/ContactDetails/ContactDetailsAddNewProp.vue 0.00% 2 Missing ⚠️
...mponents/ContactDetails/ContactDetailsProperty.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Adding the Line manager field created an empty x-managersname property and
then immediately tried to focus the newly rendered editor. When the property
had no matching contact value, the select received an undefined value and no
focusable field was available.

This produced the following JavaScript errors:

- No focusable element found for property x-managersname
- TypeError: can't access property "toLowerCase", this.localValue is undefined

Keep empty manager properties represented as an empty string, guard select
matching before lowercasing the local value, and store the only available
manager using the vCard display name plus UID parameter instead of the
internal contact key.

Fixes nextcloud#4454

Signed-off-by: Nicolas Gelot <nicolas.gelot@e.email>
@nfk nfk force-pushed the fix/line-manager-property branch from bb82bc4 to f7f6af4 Compare May 7, 2026 20:07
@nfk nfk requested a review from hamza221 May 18, 2026 07:52
@nfk
Copy link
Copy Markdown
Author

nfk commented May 19, 2026

@hamza221 @GVodyanov could you consider this MR? or let me know if some other changes are required. Thanks.

@hamza221
Copy link
Copy Markdown
Contributor

@hamza221 @GVodyanov could you consider this MR? or let me know if some other changes are required. Thanks.

Hello, Really sorry for the delay, I will give it another review this week

@hamza221

This comment was marked as low quality.

@hamza221
Copy link
Copy Markdown
Contributor

/backport to stable8.3

@hamza221
Copy link
Copy Markdown
Contributor

/backport to stable8.5

@hamza221 hamza221 merged commit 1b4fa47 into nextcloud:stable8.3 May 21, 2026
43 of 44 checks passed
@welcome
Copy link
Copy Markdown

welcome Bot commented May 21, 2026

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@backportbot
Copy link
Copy Markdown

backportbot Bot commented May 21, 2026

The backport to stable8.3 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable8.3
git pull origin stable8.3

# Create the new backport branch
git checkout -b backport/5304/stable8.3

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f7f6af4d

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5304/stable8.3

Error: Failed to check for changes with origin/stable8.3: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@github-actions
Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants