feat(circle-details): allow setting avatar image for circle#5293
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
2a114c1 to
eb90eef
Compare
|
@kra-mo following your suggestion: I positioned the avatar buttons beneath the name and description in edit mode and styled them closer to the reference in this issue. The PR description has been updated with screenshots and a short video showing the current state. Two questions I'd appreciate your input on:
Besides that, I'm also aware that probably a spacing between the buttons is needed and also some margin from the main edit mode "Cancel" and "Save" buttons. Just waiting for another round of input before moving forward. Any other thoughts are welcome :) |
eb90eef to
a5892d4
Compare
The widths should definitely be homogeneous. They should also have margins between them.
Since there is a "Cancel" button, the second behavior makes more sense. |
927fa24 to
a7b202b
Compare
|
@kra-mo thanks for the input, really appreciated! I've adopted your suggestions and updated the implementation. Also updated the main comment of this PR with new screenshots and a short video demoing the current state. |
a7b202b to
ccadcf6
Compare
6bc1efc to
1893d10
Compare
@kra-mo good idea! I've adjusted the PR accordingly, here are some screenshots:
|
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
…ing when saving/deleting avatar Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
1893d10 to
c8be982
Compare
f37d4cd to
b437745
Compare
|
@cristianscheid I was talking about a layout similar to this for the dialog:
And I'd also like if the input fields for the title and description could have a reduced maximum width, and the buttons there could have the same width:
Using NcFormGroup/NcFormBox. Neither are a blocker, but it would be nice to have these in a follow-up. |
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
b437745 to
76b825c
Compare





Summary
Screenshots