feat: add core:audio2text:subtitles task type, register file action#577
Merged
Conversation
edward-ly
force-pushed
the
feat/noid/subtitles-file-action
branch
2 times, most recently
from
June 17, 2026 00:50
43ab519 to
5284315
Compare
1 task
edward-ly
force-pushed
the
feat/noid/subtitles-file-action
branch
2 times, most recently
from
June 17, 2026 01:49
1f404c4 to
83024f3
Compare
1 task
edward-ly
marked this pull request as ready for review
June 18, 2026 15:51
Contributor
Author
|
Question: do we want to try to maintain compatibility with NC 33 on the |
edward-ly
force-pushed
the
feat/noid/subtitles-file-action
branch
from
June 19, 2026 00:14
83024f3 to
7bddb9c
Compare
julien-nc
force-pushed
the
feat/noid/subtitles-file-action
branch
2 times, most recently
from
June 24, 2026 10:40
b803865 to
4e51314
Compare
Member
|
I hope you don't mind, I added some changes
It is quite convenient to keep the compatibility with the last 2 or 3 NC versions. If we find a serious bug, we can publish one single release for all the supported NC versions. IMHO let's keep the compatibility with 33 for now. |
julien-nc
self-requested a review
June 24, 2026 10:45
edward-ly
force-pushed
the
feat/noid/subtitles-file-action
branch
from
July 13, 2026 20:29
4e51314 to
907b7d8
Compare
Contributor
Author
|
@julien-nc What's the status of this PR right now? Is there anything else that needs urgent fixing? |
Signed-off-by: Edward Ly <contact@edward.ly>
…will get in nextcloud/ocp soon use php 8.3 in phpunit action Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
edward-ly
force-pushed
the
feat/noid/subtitles-file-action
branch
from
July 17, 2026 04:16
907b7d8 to
006b28b
Compare
Assisted-by: OpenCode:GLM-5.2 Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers a file action and adds support for the new
core:audio2text:subtitlestask type. TheOCP\TaskProcessing\TaskTypes\AudioToTextSubtitlesclass is imported conditionally to maintain compatibility with NC versions older than 35.To Fix
This does not seem to have any adverse affect on the tasks themselves, but when opening finished subtitles tasks, the browser currently reports a few errors in the console such as(done)GET https://nextcloud.local/ocs/v2.php/apps/assistant/api/v1/file/104/inforeturning a 404 status.Limitations
Currently, the Save this media button for output files automatically appends the
.srtextension for.srtfiles, but not for.vttfiles. This seems to be a limitation of the PHP Mimey package as it doesn't recognize thetext/vttMIME type.By contrast, the Download this media button automatically appends the
.vttextension for.vttfiles, but not for.srtfiles for me. Since the browser/OS looks to be doing the MIME type to extension conversion at that point, I'm not sure if there's anything we can do there.🤖 AI (if applicable)