fix(auto-upload): work policy

[alperozturk96]

Changes

Auto upload content insertion done in ContentObserver
Fixes auto upload work policy since ContentObserver may trigger auto upload worker multiple times it was causing Job cancellation
ensureActiveness of Auto upload worker
Check pending files in AutoUploadWorker instead of relying content uri since entries previously inserted

[alperozturk96]

/backport to stable-3.36

[alperozturk96]

Don't interfere, work manager already handling it via policy.

[tobiasKaminsky]

java.lang.NullPointerException: Parameter specified as non-null is null: method com.nextcloud.client.jobs.autoUpload.FileSystemRepository.<init>, parameter dao
	at com.nextcloud.client.jobs.autoUpload.FileSystemRepository.<init>(FileSystemRepository.kt)
	at com.nextcloud.client.jobs.BackgroundJobFactory.createContentObserverJob(BackgroundJobFactory.kt:138)
	at com.nextcloud.client.jobs.BackgroundJobFactory.createWorker(BackgroundJobFactory.kt:86)
	at com.nextcloud.client.jobs.BackgroundJobFactoryTest.content_observer_worker_is_created(BackgroundJobFactoryTest.kt:154)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)

[tobiasKaminsky]

please fix unit test

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16555.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	42	42
Correctness	75	75
Dodgy code	252	252
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	34	34
Performance	43	43
Security	18	18
Total	474	474

[alperozturk96]

please fix unit test