Skip to content

fix(deps): bump ical.js from 2.1.0 to ^2.2.1#75

Open
renovate[bot] wants to merge 2 commits intomainfrom
renovate/ical.js-2.x
Open

fix(deps): bump ical.js from 2.1.0 to ^2.2.1#75
renovate[bot] wants to merge 2 commits intomainfrom
renovate/ical.js-2.x

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented Jul 8, 2025

This PR contains the following updates:

Package Change Age Confidence
ical.js ^2.1.0^2.2.1 age confidence

Release Notes

kewisch/ical.js (ical.js)

v2.2.1

Compare Source

What's Changed

Full Changelog: kewisch/ical.js@v2.2.0...v2.2.1

v2.2.0

Compare Source

What's Changed

New Contributors

Full Changelog: kewisch/ical.js@v2.1.0...v2.2.0


Configuration

📅 Schedule: Branch creation - "before 5am on tuesday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from GretaD as a code owner July 8, 2025 01:49
@renovate renovate bot requested a review from st3iny as a code owner July 8, 2025 01:49
@renovate renovate bot force-pushed the renovate/ical.js-2.x branch from 53eb0f5 to ce8f1e5 Compare August 8, 2025 10:03
@renovate renovate bot changed the title fix(deps): bump ical.js from 2.1.0 to ^2.2.0 fix(deps): bump ical.js from 2.1.0 to ^2.2.1 Aug 8, 2025
@st3iny
Copy link
Copy Markdown
Collaborator

st3iny commented Aug 12, 2025

Documentation and type checking are failing due to an upstream bug 🤡

node_modules/ical.js/dist/types/vcard_time.d.ts:51:5 - error TS2610: 'icaltype' is defined as an accessor in class 'Time', but is overridden here in 'VCardTime' as an instance property.

51     icaltype: string;
       ~~~~~~~~

@susnux
Copy link
Copy Markdown
Contributor

susnux commented Aug 12, 2025

kewisch/ical.js#916

@renovate renovate bot force-pushed the renovate/ical.js-2.x branch from ce8f1e5 to 4860021 Compare August 31, 2025 13:22
@renovate renovate bot force-pushed the renovate/ical.js-2.x branch from 4860021 to 8e8e8ad Compare September 25, 2025 19:03
@renovate renovate bot force-pushed the renovate/ical.js-2.x branch from 8e8e8ad to 3ec4bb8 Compare October 21, 2025 11:47
@renovate renovate bot requested a review from pabzm as a code owner October 21, 2025 11:47
@st3iny
Copy link
Copy Markdown
Collaborator

st3iny commented Oct 21, 2025

Still waiting for another release of ical.js. The fix was already merged upstream.

@renovate renovate bot force-pushed the renovate/ical.js-2.x branch from 3ec4bb8 to e12fee2 Compare November 10, 2025 20:49
@renovate renovate bot force-pushed the renovate/ical.js-2.x branch from e12fee2 to 970e7c0 Compare November 18, 2025 11:10
@renovate renovate bot force-pushed the renovate/ical.js-2.x branch from 970e7c0 to bf66f10 Compare February 2, 2026 19:58
@AndyScherzinger
Copy link
Copy Markdown
Contributor

Current release shipping the fix @st3iny?

@pabzm
Copy link
Copy Markdown
Contributor

pabzm commented Feb 3, 2026

@AndyScherzinger I only see the release from August 2025 at https://github.com/kewisch/ical.js/releases – do you see a newer one somewhere else?

@st3iny
Copy link
Copy Markdown
Collaborator

st3iny commented Feb 4, 2026

No, unfortunately not. The fix is only on their main branch. I can poke kewisch regarding a soonish release.

@renovate renovate bot force-pushed the renovate/ical.js-2.x branch from bf66f10 to 4363266 Compare March 5, 2026 20:44
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot force-pushed the renovate/ical.js-2.x branch from 4363266 to c01e021 Compare March 27, 2026 12:45
Is not critical as the upstream typing information is based on their
Jsdoc anyway. They are not using TypeScript so it doesn't make sense to
be overly strict here.

```
node_modules/ical.js/dist/types/vcard_time.d.ts:51:5 - error TS2610: 'icaltype' is defined as an accessor in class 'Time', but is overridden here in 'VCardTime' as an instance property.

51     icaltype: string;
       ~~~~~~~~
```

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny
Copy link
Copy Markdown
Collaborator

st3iny commented Mar 28, 2026

So, I disabled the type checking for third-party library code to make the documentation build again.

It is not critical as the upstream typing information is based on their Jsdoc and thus not reliable. They are not using TypeScript so it doesn't make sense to be overly strict here.

PS: I didn't hear back from kewisch.

@GretaD @pabzm Feel free to move on like this :)

@renovate
Copy link
Copy Markdown
Contributor Author

renovate bot commented Mar 28, 2026

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants