fix(deps): bump ical.js from 2.1.0 to ^2.2.1#75
Conversation
53eb0f5 to
ce8f1e5
Compare
|
Documentation and type checking are failing due to an upstream bug 🤡 |
ce8f1e5 to
4860021
Compare
4860021 to
8e8e8ad
Compare
8e8e8ad to
3ec4bb8
Compare
|
Still waiting for another release of ical.js. The fix was already merged upstream. |
3ec4bb8 to
e12fee2
Compare
e12fee2 to
970e7c0
Compare
970e7c0 to
bf66f10
Compare
|
Current release shipping the fix @st3iny? |
|
@AndyScherzinger I only see the release from August 2025 at https://github.com/kewisch/ical.js/releases – do you see a newer one somewhere else? |
|
No, unfortunately not. The fix is only on their main branch. I can poke kewisch regarding a soonish release. |
bf66f10 to
4363266
Compare
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
4363266 to
c01e021
Compare
Is not critical as the upstream typing information is based on their
Jsdoc anyway. They are not using TypeScript so it doesn't make sense to
be overly strict here.
```
node_modules/ical.js/dist/types/vcard_time.d.ts:51:5 - error TS2610: 'icaltype' is defined as an accessor in class 'Time', but is overridden here in 'VCardTime' as an instance property.
51 icaltype: string;
~~~~~~~~
```
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
|
So, I disabled the type checking for third-party library code to make the documentation build again. It is not critical as the upstream typing information is based on their Jsdoc and thus not reliable. They are not using TypeScript so it doesn't make sense to be overly strict here. PS: I didn't hear back from kewisch. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
^2.1.0→^2.2.1Release Notes
kewisch/ical.js (ical.js)
v2.2.1Compare Source
What's Changed
pull/914
Full Changelog: kewisch/ical.js@v2.2.0...v2.2.1
v2.2.0Compare Source
What's Changed
New Contributors
Full Changelog: kewisch/ical.js@v2.1.0...v2.2.0
Configuration
📅 Schedule: Branch creation - "before 5am on tuesday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.