fix: export formatCssRule instead of undefined formatCss - #190
Open
samuelcaldas wants to merge 2 commits into
Open
samuelcaldas wants to merge 2 commits into
samuelcaldas wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Code <noreply@anthropic.com>
- Export formatCssRule instead of undefined formatCss in exportFunctionsForTesting - Update unit test to verify formatCssRule - Add .playwright-mcp to .gitignore Co-Authored-By: Claude Code <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a Node.js test/import failure caused by exportFunctionsForTesting() still referencing the old formatCss symbol after it was refactored to formatCssRule, leading to ReferenceError: formatCss is not defined.
Changes:
- Updated
exportFunctionsForTesting()to exportformatCssRuleinstead of the removedformatCss. - Updated the unit test to validate
formatCssRule()output. - Updated
.gitignore(adds.playwright-mcp) and synchronized the package version recorded inpackage-lock.json.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
ai2html.js |
Fixes Node test exports by exporting formatCssRule (prevents ReferenceError). |
test/utils-test.js |
Updates unit coverage to call/assert formatCssRule() instead of formatCss(). |
package-lock.json |
Aligns lockfile’s recorded package version with the current package version. |
.gitignore |
Ignores .playwright-mcp and normalizes the existing ai2html-config.json entry. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
ai2html.js,formatCsswas refactored intoformatCssRule, butexportFunctionsForTesting()andtest/utils-test.jsstill referencedformatCss, causing aReferenceError: formatCss is not definedwhen importing in Node.js or runningnpm test.Changes
exportFunctionsForTestingto exportformatCssRuleinai2html.jstest/utils-test.jsto testformatCssRule()🤖 Generated with Claude Code