Conversation
smk4664
left a comment
There was a problem hiding this comment.
This great so far. I don't see any issues with these commands or changes.
|
@jeffkala I'm not sure what we're going to do about Python 3.13 support since the f5 sdk is no longer maintained and it hasn't been updated for Py3.13. Should we remove Py3.13 from CI for now? |
Maybe just move it to use netmiko for f5? https://github.com/ktbyers/netmiko/blob/develop/netmiko/f5/f5_tmsh_ssh.py |
Can that be a follow-up so it doesn't block this feature? This is supposed to be done by tomorrow and still needs changes in os upgrades. |
smk4664
left a comment
There was a problem hiding this comment.
This is great! And I agree, we should remove testing for 3.13 for now as we get a plan to support F5 through Netmiko.
|
BTW I opened an issue in this repo to track replacing the F5 sdk library. |
|
do what you need to get this passing, if turning off py3.13 is the answer short term I'm good with it. |
| self.native.open() | ||
|
|
||
| def reboot(self, wait_for_reload=False, **kwargs): | ||
| def reboot(self, wait_for_reload=False, timeout=3600, confirm=None): |
There was a problem hiding this comment.
sure we don't need kwargs? I feel like you're right to move them, but does the backend library support passing other "things" that we need to support.
What's Changed
_wait_for_rebootfor various platforms by adding asleep(10)Sample OS Upgrade script:
TODO