Repository navigation
fix(wallet): return an error instead of panicking on invalid force_small_change_as_fee - #691
Merged
chenyukang merged 1 commit intoNov 16, 2026
Conversation
|
Reproduced the original issue on the base version and verified the fix in this PR. Invalid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WalletSubCommand::transfercalledunwrap()when parsingforce_small_change_as_fee. On the CLI path this is harmless, because clap validates--max-tx-feefirst. The API server'stransfermethod, however, passesforce_small_change_as_feestraight from the request JSON as an uncheckedString. A value that is not a valid capacity (e.g."NOT_A_CAPACITY") therefore panics the HTTP worker instead of returning a JSON-RPC error.The panic happens inside
ApiRpcImpl::with_walletwhile therpc_clientandplugin_mgrmutexes are held, so both get poisoned. After that, everytransferandget_capacity_by_addresscall panics too, and the API server stays unusable until it is restarted.Change
Parse
force_small_change_as_feewith.transpose()?, the same way the neighbouring arguments intransferare parsed. Invalid input now comes back to API clients as aninvalid_paramserror, and the server keeps working.Testing
cargo check,cargo fmt --checkandcargo clippy --all-targetsall pass.