FEATURE: Add CompletableFuture incr, decr API#1058
Open
f1v3-dev wants to merge 1 commit intonaver:developfrom
Open
FEATURE: Add CompletableFuture incr, decr API#1058f1v3-dev wants to merge 1 commit intonaver:developfrom
f1v3-dev wants to merge 1 commit intonaver:developfrom
Conversation
f1v3-dev
force-pushed
the
feat/v2-incr-decr
branch
from
80e42eb to
24bdf53
Compare
oliviarla
reviewed
Mar 13, 2026
src/test/java/net/spy/memcached/v2/KVAsyncArcusCommandsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/net/spy/memcached/v2/KVAsyncArcusCommandsTest.java
Outdated
Show resolved
Hide resolved
f1v3-dev
force-pushed
the
feat/v2-incr-decr
branch
from
24bdf53 to
2a66bf6
Compare
oliviarla
reviewed
Mar 17, 2026
| } | ||
|
|
||
| @Test | ||
| void decrTypeMismatchException() throws ExecutionException, InterruptedException, |
Collaborator
There was a problem hiding this comment.
decrTypeMismatchException -> decrTypeNotNumberException
로 변경하는게 좋겠습니다.
collection 타입 키를 생성해서 TypeMismatch 발생시키는 테스트도 추가되면 좋겠습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
incr,decr) API 구현을 진행했습니다.두 메서드 동작 차이
incr(key, delta)incr(key, delta, initial, exp)initial로 초기화 (delta미적용)decr()도 동일한 동작 차이를 가집니다.