Fix voice packet spam and very FPS drop

[MoriskaSosiska]

Hello again!

You may choose not to pay attention to my PR, but I'd really appreciate it if you could review it because it fixes a vulnerability in the MTA client.

This fix addresses the FPS drops (up to the point where the client freezes) that occur when cheaters spam voice chat packets, causing nearby players' games to freeze or stutter due to BASS_StreamPutData slowing down execution.

I moved the 100 ms cooldown check from the client, made a few adjustments to CVoiceDataPacket, and added a check for the return value of speex_decode_int.

I also removed the reserve call and the CVoiceDataPacket constructor so that memory is only allocated if the 100 ms interval has elapsed.

This vulnerability has already been exploited by cheaters on NEXTRP and other projects, as I was told.

Thanks for taking the time to read this!😄

[DateFTP]

I'll keep that in mind, as cheaters have already touched my project.

[DateFTP]

Thank you for the fix, and we'll be waiting for the review.

[Lpsd]

Thanks for your PR, however there are several oversights here. Furthermore, we would advise that any such issues where a client can cause another client to crash, are reported privately.

We'll deal with this for the upcoming 1.7 release. In the meantime this can be protected against by monitoring packet activity (available in 1.6)

[MoriskaSosiska]

Thanks for your PR, however there are several oversights here. Furthermore, we would advise that any such issues where a client can cause another client to crash, are reported privately.

We'll deal with this for the upcoming 1.7 release. In the meantime this can be protected against by monitoring packet activity (available in 1.6)

None of you seems willing to properly engage with me. I want to help, but how should I report things to you discreetly – for example, by writing to you on Discord?

[Lpsd]

https://forum.multitheftauto.com/forum/156-private-bugs/ is monitored

[MoriskaSosiska]

https://forum.multitheftauto.com/forum/156-private-bugs/ is monitored

That sounds humiliating...

[Lpsd]

I'm not sure what you mean, this is the relevant section for private bugs.

[MoriskaSosiska]

I'm not sure what you mean, this is the relevant section for private bugs.

You keep blocking me everywhere on GitHub and Discord for made-up reasons, leaving me with no way to contact you.

Telling me to post on the forum, where the chances of anyone actually hearing me are extremely small, feels pretty humiliating.

You don't give me a chance to show you that I've changed. You only judge me based on my past mistakes.
No one wants to see things from my perspective.

I don't develop cheats, yet you keep isolating me from every platform. It's honestly hurtful.

Maybe you don't care about anything I've written, and maybe you'll block this GitHub account too, but I couldn't stay silent because this really matters to me. I'm sorry.

[Lpsd]

I haven't personally made any of those actions.

It may be wise to consider the reality; you haven't been blocked in this instance, and have been provided with a method of communication.

The private bugs section is monitored but does not necessarily receive responses. This is the same for everyone and isn't exclusive to yourself.