Use fail-safe ReadBit overload in join packet parser#4910
Merged
Dutchman101 merged 1 commit intomultitheftauto:masterfrom May 10, 2026
Merged
Use fail-safe ReadBit overload in join packet parser#4910Dutchman101 merged 1 commit intomultitheftauto:masterfrom
Dutchman101 merged 1 commit intomultitheftauto:masterfrom
Conversation
Member
Author
|
I've updated the desc with a plausible bug scenario |
sbx320
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use fail-safe ReadBit overload in join packet parser
The no-arg ReadBit() returns the bit value, not a success indicator - on
bitstream exhaustion it silently returns false, not distinguishable from
reading a 0 bit. Switch to the ReadBit(bool&) overload from bitstream.h
which wraps ReadBits internally and properly returns false on exhaustion.
Now, the ReadBit is consistent with every other read in the function, (they all early-return on failure)
Scenario where it (pre-PR) would be a problem, and how:
If the bitstream is exhausted:
ReadBit()returnsfalse- indistinguishable from "the bit was 0"m_bOptionalUpdateInfoRequired = falseinstead of failing