Filter WER crash dialogs to fail-fast exceptions only#4907
Open
Dutchman101 wants to merge 1 commit intomultitheftauto:masterfrom
Open
Filter WER crash dialogs to fail-fast exceptions only#4907Dutchman101 wants to merge 1 commit intomultitheftauto:masterfrom
Dutchman101 wants to merge 1 commit intomultitheftauto:masterfrom
Conversation
sbx320
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_CheckForWerCrash picks up any .dmp file in the private dumps folder and shows a "Security Exception" crash dialog on the next launch. The problem is it doesn't check what kind of exception the dump actually contains - so a C++ exception (like a CEGUI texture load failure, 0xE06D7363) that got dumped by WER would show up as a delayed crash dialog on the next MTA launch, even though the game kept running fine as it wasn't a fatal exception at the time it happened.
Now it checks the exception code in the dump and skips anything that isn't a real fail-fast (0xC0000409 / 0xC0000374). This stops irrelevant crash dialogs from appearing on the next launch when no actual crash happened.