Fix getVehicleSirensOn/setVehicleSirensOn for Rhino and Barracks (#4899)#4900
Merged
FileEX merged 1 commit intomultitheftauto:masterfrom May 7, 2026
Merged
Conversation
…titheftauto#4899) Rhino (432) and Barracks (433) have functional sirens in vanilla SA, but HasSirens() rejected them because they were missing VEHICLE_HAS_SIRENS in g_ulVehicleAttributes, causing the Lua siren API to return nil/false. Add the bit on both client and server tables and in the gentable generator.
FileEX
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
VEHICLE_HAS_SIRENSto Rhino (432) and Barracks (433) ing_ulVehicleAttributeson both client and server, plus thegentable_vehattrgenerator.Motivation
Resolves #4899.
Both vehicles have functional sirens in vanilla SA, but
HasSirens()rejected them because the bit was missing from the attribute table. As a result,getVehicleSirensOnreturnednilandsetVehicleSirensOnwas a no-op.Test plan
setVehicleSirensOn(vehicle, true), thengetVehicleSirensOn(vehicle). Expected:true.setVehicleSirensOn(vehicle, false), thengetVehicleSirensOn(vehicle). Expected:false.Checklist