Skip to content

[examples] Add eslint to TanStack example so pnpm eslint works#4297

Open
CiscoFran10 wants to merge 4 commits intomui:masterfrom
CiscoFran10:fix/tanstack-example-eslint-dep
Open

[examples] Add eslint to TanStack example so pnpm eslint works#4297
CiscoFran10 wants to merge 4 commits intomui:masterfrom
CiscoFran10:fix/tanstack-example-eslint-dep

Conversation

@CiscoFran10
Copy link
Contributor

The TanStack Start example had a lint script that runs eslint but did not declare eslint as a dependency. That made pnpm eslint fail when it ran workspace lints. This PR adds eslint as a devDependency to the example so pnpm eslint works again.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 11, 2026

commit: 5e33e0f

@mui-bot
Copy link

mui-bot commented Mar 11, 2026

Bundle size report

Bundle Parsed size Gzip size
@base-ui/react 0B(0.00%) 0B(0.00%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@netlify
Copy link

netlify bot commented Mar 11, 2026

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 9611d1f
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/69b23156aeaed100089f6519
😎 Deploy Preview https://deploy-preview-4297--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice observation. 👍

@LukasTy LukasTy added examples Relating to /examples. type: bug It doesn't behave as expected. labels Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples Relating to /examples. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants