Add gettextpo gem specification file#480
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the necessary configuration to integrate the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a new gem specification file, gettextpo.gem. The changes are straightforward, but there is one point of feedback regarding repository conventions. The gem name gettextpo does not follow the mruby- prefixing guideline mentioned in the repository's README.md. I've suggested a change to align with the project's standards.
| @@ -0,0 +1,8 @@ | |||
| name: gettextpo | |||
There was a problem hiding this comment.
According to the repository's README.md guidelines, gem names should be prefixed with mruby-. While the pull request description mentions this is intentional because the gem also supports CRuby, this repository (mgem-list) is specifically for mruby gems. To maintain consistency with the project's contribution guidelines, please consider renaming the gem to mruby-gettextpo.
The guideline can be found in README.md on line 34:
- prefix should be
mruby-
name: mruby-gettextpo
References
- The repository's
README.mdfile specifies that gem names should be prefixed withmruby-to maintain consistency within the project. (link)
There was a problem hiding this comment.
If this is a dual-compatible gem mentioned in #479 (and it seems so), mruby- prefix is not mandatory.
Hello,
This pull request introduces gettextpo, a GNU gettext PO parser library for mruby (and CRuby, so this has no
mruby-prefix) that wraps the libgettextpo C library.Thank you.