Skip to content

Add gettextpo gem specification file#480

Merged
matz merged 1 commit intomruby:masterfrom
gemmaro:add/gettextpo
Mar 11, 2026
Merged

Add gettextpo gem specification file#480
matz merged 1 commit intomruby:masterfrom
gemmaro:add/gettextpo

Conversation

@gemmaro
Copy link
Copy Markdown
Contributor

@gemmaro gemmaro commented Mar 10, 2026

Hello,

This pull request introduces gettextpo, a GNU gettext PO parser library for mruby (and CRuby, so this has no mruby- prefix) that wraps the libgettextpo C library.

Thank you.

@gemmaro gemmaro requested a review from matz as a code owner March 10, 2026 23:45
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the necessary configuration to integrate the gettextpo library, a GNU gettext PO parser, into the project. This integration enables robust parsing of PO files, leveraging the libgettextpo C library for enhanced internationalization capabilities within both mruby and CRuby environments.

Highlights

  • New Gem Specification: Added the gettextpo.gem specification file, which defines the metadata for integrating the gettextpo library. This library is a GNU gettext PO parser for mruby and CRuby, wrapping the libgettextpo C library.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • gettextpo.gem
    • Added the gem specification file for gettextpo.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new gem specification file, gettextpo.gem. The changes are straightforward, but there is one point of feedback regarding repository conventions. The gem name gettextpo does not follow the mruby- prefixing guideline mentioned in the repository's README.md. I've suggested a change to align with the project's standards.

@@ -0,0 +1,8 @@
name: gettextpo
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the repository's README.md guidelines, gem names should be prefixed with mruby-. While the pull request description mentions this is intentional because the gem also supports CRuby, this repository (mgem-list) is specifically for mruby gems. To maintain consistency with the project's contribution guidelines, please consider renaming the gem to mruby-gettextpo.

The guideline can be found in README.md on line 34:

  • prefix should be mruby-
name: mruby-gettextpo
References
  1. The repository's README.md file specifies that gem names should be prefixed with mruby- to maintain consistency within the project. (link)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a dual-compatible gem mentioned in #479 (and it seems so), mruby- prefix is not mandatory.

@matz matz merged commit 809a9ac into mruby:master Mar 11, 2026
3 checks passed
@gemmaro gemmaro deleted the add/gettextpo branch March 11, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants