Skip to content

Track secondary sync metrics on our dashboard. - #7540

Merged
bendk merged 1 commit into
mozilla:mainfrom
bendk:bdk/push-nvwyyynyopxy
Aug 14, 2026
Merged

Track secondary sync metrics on our dashboard.#7540
bendk merged 1 commit into
mozilla:mainfrom
bendk:bdk/push-nvwyyynyopxy

Conversation

@bendk

@bendk bendk commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Added panels for total sync counts and average sync time on the main dashboard. Added panels for average sync time to the details page. Both of these use a 7 day moving average. Refactored the code so that it will hopefully be easier to add more of these metrics if we want to later on.

Added rust-logins engine for Desktop. This captures users using the Rust logins component, which is what nightly is on nowadays.

Changed the slug for the details page from sync-sync-details to sync-sync-extra. I'm not sure why, but the old slug started getting import errors. I believe was was related to me uploading it to the wrong folder, then deleted it.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@bendk
bendk requested a review from skhamis August 12, 2026 20:10
@bendk

bendk commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

You can see these on https://yardstick.mozilla.org/d/sync-main/sync. They're looking pretty good to me.

Il need to update our ETL to get the average sync times working on mobile. I'll hopefully get that done this week.

@bendk
bendk force-pushed the bdk/push-nvwyyynyopxy branch 3 times, most recently from 7f90cc1 to 0136615 Compare August 13, 2026 19:04
Added panels for total sync counts and average sync time on the main
dashboard.  Added panels for average sync time to the details page.
Both of these use a 7 day moving average.  Refactored the code so that
it will hopefully be easier to add more of these metrics if we want to
later on.

Also:
  - Added `rust-logins` engine for Desktop.  This captures users using
    the Rust logins component, which is what nightly is on nowadays.
  - Added CC key regeneration metrics for iOs.
  - Put the error panel below the sync metric panels
  - Changed the slug for the details page from `sync-sync-details` to
    `sync-sync-extra`.  I'm not sure why, but the old slug started
    getting import errors.  I believe was was related to me uploading it
    so many times.
@bendk
bendk force-pushed the bdk/push-nvwyyynyopxy branch from 0136615 to 0c5f618 Compare August 13, 2026 20:22

@skhamis skhamis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, looks great!

application,
engine_name,
success_rate,
0 as avg_sync_time, -- TODO: make this work on Mobile

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we don't forgot about this in someway since mobile will have "fast" sync times lol

@bendk
bendk added this pull request to the merge queue Aug 14, 2026
Merged via the queue into mozilla:main with commit a22aae0 Aug 14, 2026
14 checks passed
@bendk
bendk deleted the bdk/push-nvwyyynyopxy branch August 14, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants