impr(quotes): add 10 English quotes (@yohaann196)#7634
Open
yohaann196 wants to merge 9 commits intomonkeytypegame:masterfrom
Open
impr(quotes): add 10 English quotes (@yohaann196)#7634yohaann196 wants to merge 9 commits intomonkeytypegame:masterfrom
yohaann196 wants to merge 9 commits intomonkeytypegame:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds 10 new English quote entries to the frontend’s static quotes dataset (english.json), extending the pool of quotes available to the app.
Changes:
- Appended 10 new quote objects (text/source/id/length) to
frontend/static/quotes/english.json. - Continued the quote
idsequence from the prior max id.
You can also share your feedback on Copilot code review. Take the survey.
22 tasks
Co-authored-by: yohaann196 <229655281+yohaann196@users.noreply.github.com>
…quote Co-authored-by: yohaann196 <229655281+yohaann196@users.noreply.github.com>
…quotes 60+ chars Co-authored-by: yohaann196 <229655281+yohaann196@users.noreply.github.com>
… install side effects) Co-authored-by: yohaann196 <229655281+yohaann196@users.noreply.github.com>
impr(quotes): add 10 English quotes (@yohaann196)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 10 English quotes (each entry has the quote, source, id, and character length)
Quotes added:
• “It was the best of times, it was the worst of times, it was the age of wisdom, it was the age of foolishness.” - A Tale of Two Cities
• “It is our choices, Harry, that show what we truly are, far more than our abilities.” - Harry Potter and the Chamber of Secrets
• “I am no bird; and no net ensnares me: I am a free human being with an independent will.” - Jane Eyre
• “The most important things are the hardest to say. They are the things you get ashamed of, because words diminish them.” - The Body
• “I took a deep breath and listened to the old brag of my heart: I am, I am, I am.” - The Bell Jar
• “Two roads diverged in a wood, and I took the one less traveled by, and that has made all the difference.” - The Road Not Taken
• “The world breaks everyone, and afterward, some are strong at the broken places.” - A Farewell to Arms
• “So we beat on, boats against the current, borne back ceaselessly into the past. Old sport.” - The Great Gatsby
• “One must always be careful of books, and what is inside them, for words have the power to change us.” - Clockwork Angel
• “There is no greater agony than bearing an untold story inside you.” - I Know Why the Caged Bird Sings
All quotes are provided in English.
Checks
• Adding quotes
• Included the full quote text in the description so the content can be verified.