fix(account-chart): prevent scroll when clicking outside chart (@byseif21)#7608
Open
byseif21 wants to merge 2 commits intomonkeytypegame:masterfrom
Open
fix(account-chart): prevent scroll when clicking outside chart (@byseif21)#7608byseif21 wants to merge 2 commits intomonkeytypegame:masterfrom
byseif21 wants to merge 2 commits intomonkeytypegame:masterfrom
Conversation
github-actions
bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents unintended table scrolling when the account history chart is clicked in empty areas by gating the click behavior on having an active chart element.
Changes:
- Only scroll/select a result row when the chart has an active tooltip element.
- Add a guard around using
accountHistoryActiveIndex. - Fix
.resultRow[data-id=...]selector typo (missing closing]).
byseif21
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: clicking chart labels scrolls to a record
1- account history chart under the filters.
2- click on the “Words per Minute” or “Accuracy” labels on the sides of the chart.
3- page scrolls to a record in the results table even if no chart dot was clicked.