SQL-3268: Migrate and update (NOT) IN tests for implicit type conversion of extended JSON strings#166
Open
mattChiaravalloti wants to merge 4 commits into
Open
SQL-3268: Migrate and update (NOT) IN tests for implicit type conversion of extended JSON strings#166mattChiaravalloti wants to merge 4 commits into
mattChiaravalloti wants to merge 4 commits into
Conversation
Collaborator
Author
There was a problem hiding this comment.
Note that neither of these tests actually included coverage for implicit type conversion of extended JSON encoded strings since neither query contained such string values! That's why new tests in the e2e file look slightly different!
jpowell-mongo
approved these changes
Jul 6, 2026
jpowell-mongo
left a comment
jpowell-mongo
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for catching this! Apologies for the miss, I should have also checked the mql codegen path along with the sql codegen path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the spec/query tests for
INandNOT INthat intended to cover implicit type conversion of extended JSON encoded strings into the e2e test suite, and updates those tests to cover the intended behavior on both sides of the operators. See the ticket for more info.As part of this change, I realized that we were unconditionally codegenning
air::MqlOperator::NotInto$nin, which was invalid. I updated theair::MqlOperator::NotIncodepath to mimic whatair::SqlOperator::NotIndoes. That is, it now codegens as{$not: {$in: ... }}instead of{$nin: ...}. That was a quick drive-by fix! I considered filing a separate bug ticket, but I figured why block these new e2e tests on a bug ticket when it's just essentially a one-liner change.This is a tech-debt ticket.