PYTHON-5917 Fix document_class generic alias check on PyPy#2917
Draft
blink1073 wants to merge 1 commit into
Draft
PYTHON-5917 Fix document_class generic alias check on PyPy#2917blink1073 wants to merge 1 commit into
blink1073 wants to merge 1 commit into
Conversation
issubclass() does not raise TypeError for generic aliases like dict[str, Any] or SON[str, Any] on all Python implementations (e.g. PyPy), so the exception-based fallback to check __origin__ never ran, causing a spurious TypeError. Resolve __origin__ before the subclass check instead of relying on catching the error.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5917
Changes in this PR
Fixes a PyPy-only failure when validating a parameterized generic
document_class(e.g.dict[str, Any],SON[str, Any]).Passing build: https://spruce.corp.mongodb.com/version/6a4bd47a30181800078c2ed7/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
Test Plan
Covered by existing unit tests exercising generic
document_classvalues; verified passing on PyPy via the Evergreen patch linked above.Checklist
Checklist for Author
Checklist for Reviewer