fix(extra-fields): не ALTER site_content, валидация key (#645) - #646
Open
Ibochkarev wants to merge 2 commits into
Open
fix(extra-fields): не ALTER site_content, валидация key (#645)#646Ibochkarev wants to merge 2 commits into
Ibochkarev wants to merge 2 commits into
Conversation
Reject msProduct/msCategory (modResource STI), resolve unprefixed Phinx tables from mysql metaMap, and validate field keys as SQL identifiers.
Member
Author
|
Ручная проверка на project.test после sync PHP +
|
…ck (#645) Assert ExtraFieldsService rejects STI classes and invalid keys before save, and point the MODX_CORE_PATH-less migrations path at the package root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Исправление создания Extra Fields из #645: не вешать колонки на
modResource/site_content, чинить двойной префикс таблицы в Phinx и отклонять невалидные ключи (кириллица и т.п.).msProductData(своя таблицаms3_products)msProduct/msCategoryубраны из dropdown во Vue; сервер отклоняет классы без собственногоmetaMap['table']MigrationGeneratorчитает unprefixed имя из mysqlmetaMap(prefix добавляетphinx.php)site_contentkeyчерезGridColumnRules::isValidSqlIdentifier(+ клиентский паттерн)Тип изменений
Связанные Issues
Closes #645
Как это было протестировано?
Конфигурация тестирования:
fix/issue-645-extra-fields-msproductЧеклист
Дополнительные заметки
Out of scope: ALTER
site_content, новаяmsCategoryData, переписывание всего Phinx runtime, серверный allowlist классов для Vue (сейчас gate наcanHostExtraField+ урезанный UI).