fix(vue): nested category checks survive reload on product Categories tab - #642
Open
Ibochkarev wants to merge 1 commit into
Open
fix(vue): nested category checks survive reload on product Categories tab#642Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
ResourceCategoryTree was emitting a truncated selection after loadRoot, so nested additional categories disappeared from the hidden field and were wiped from ms3_product_categories on the next save.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
После F5 на вкладке товара «Категории» галки вложенных дополнительных категорий пропадали. Hidden
categoriesтерял id, которых не было на первой странице ленивого дерева. Повторное сохранение чистилоms3_product_categories.В
ResourceCategoryTreecheckedSetтеперь засевается изmodelValueдоloadRoot(immediatewatch). После fetch selection не эмитится усечённым списком. Emit только при действии пользователя или когда реально добавили locked id. Writer wipe+insert не меняли.Тип изменений
Связанные Issues
Closes #641
Отчёт: https://modx.pro/help/25733
Как это было протестировано?
Ручная проверка на https://project.test/manager (товар #25
QA Combo Title, memberships2,3,4,12):vueManager(npm run build) и синхронизировалvue-distна сайт.?a=resource/update&id=25, вкладка Categories.categoriesиExt form.getValues().categories=[2,3,4,12].[2,4,12](вложенные 4 и 12 остаются).ms3_product_categoriesпо-прежнему2,3,4,12.npm test,npm run lint:ci)Конфигурация тестирования:
fix/issue-641-nested-category-checksотbetaСкриншоты (если применимо)
Не применимо.
Чеклист
npm run lint:ciдля Vue)Дополнительные заметки
Вне скоупа PR: фильтр
context_key/defaultRootIdдля состава дерева (второй симптом с форума),show_in_tree=0как доп. категории.