Repository navigation
boundname fixes - #470
Merged
Merged
boundname fixes#470
Conversation
wpbonelli
added
bug
wpbonelli
force-pushed
the
boundname-text
branch
2 times, most recently
from
October 15, 2026 03:27
5d6e5bb to
7069b86
Compare
Merged
wpbonelli
force-pushed
the
boundname-text
branch
from
October 15, 2026 16:57
7069b86 to
3d1fe36
Compare
wpbonelli
added a commit
that referenced
this pull request
Oct 15, 2026
Some fields are valid only when another option is set, e.g. EVT's petm0 with SURF_RATE_SPECIFIED. The DFNs now have a when attribute (MODFLOW-ORG/modflow-devtools#395) indicating this. Use it Boundnames move onto the same mechanism after #470
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A trailing optional untagged string column (a boundname, a name file's pname) is absent when left off the line, so an empty one means absent: convert it to None, the one "no boundname". The generator finds these columns from the DFNs. Any other string, union string arm or file can't be empty: MF6 fails on one or gives it no meaning. Supersedes modflowpy#465. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An empty string reads back as nothing, or an error, in most places, so the writer raises on one, as a backstop to the field validators. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wpbonelli
force-pushed
the
boundname-text
branch
from
October 15, 2026 17:45
3d1fe36 to
fa019d1
Compare
wpbonelli
marked this pull request as ready for review
October 15, 2026 21:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boundname/pname`supersedes #465