Repository navigation
fix: share FastMCP in-flight gauges across HTTP apps - #465
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling the in-flight HTTP gauge caused a duplicate collector error when a second FastMCP HTTP app started. Apply the existing shared-gauge adapter to the default registry as well as custom registries. Upstream Instrumentator still creates a gauge per middleware instance and offers no collector-reuse hook.
Expand the regression to hold requests open in two simultaneous HTTP apps. Verify the shared count reaches 2, method and handler labels are preserved, separately configured gauges stay independent, and counts return to zero after completion.
Validation: regression failed before the fix; all 688 tests pass with 100% line coverage. Ruff and ty pass. Standards and spec reviews found no issues.
Closes #455.