Repository navigation
fix: redact independently rendered structlog records in Sentry - #462
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Independently rendered structlog records with a missing or non-string message can leak sensitive fields into Sentry issues and later breadcrumbs. Add an opt-in
SentryJSONRendererthat preserves JSON output and marks the rendered string for the existing redaction pipeline. Identical unmarked stdlib JSON stays unchanged.Use the renderer in the built-in logging instrument and document external configuration in the migration guide and seam ADR.
Regression tests reproduce the envelope leak before the fix and verify serialized payloads, later breadcrumbs, callback ordering, suppression, and unchanged stdout JSON.
Validation: 679 tests pass with 100% line coverage; Ruff, ty 0.0.100, and the strict docs build pass. Standards and spec reviews found no issues.
Closes #450.