Updated Lobatto - #4808
Open
HansOlsson wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
As for the epsilion - originally it was Not being clever means rewriting this as: Which is basically the same as: or: |
Contributor
Author
|
Minor note: Changing y to abs(y) ensures that the integral is non-negative, since all of the quadrature-weights are positive - (it's still a bit of a hack since abs(y) may not be sufficiently differentiable). That's normal for quadrature formulas. However, time-integration algorithms sometimes fail that (like Nyström's and Fehlberg's methods with one negative B-value each). |
Contributor
|
I've tried it: works as expected. Thanks a lot! |
AHaumer
approved these changes
Sep 9, 2026
Contributor
|
solves #4807 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution outlined in #4800
Might add a more detailed description as a comment.
The basic ideas are:
is+delta==istrick.max(abs(is), isabs/10)- we could change the factor10- or even just useisabs. It's a trade-off.