Document how values are computed based on resonance frequency.#4780
Open
HansOlsson wants to merge 1 commit intomodelica:masterfrom
Open
Document how values are computed based on resonance frequency.#4780HansOlsson wants to merge 1 commit intomodelica:masterfrom
HansOlsson wants to merge 1 commit intomodelica:masterfrom
Conversation
Also makes the models unit correct.
HansOlsson
added
L: Electrical.Analog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It also makes the models unit correct, but the main goal is to make it easier to explain the models - by replacing literal values with unclear relations with somewhat understandable parameters, and clear formulas.
(It could be made even better by explaining the derivation of them.)
A benefit is that it is straightforward to modify the resonance frequency (or resistance.) and re-run the simulation to see the impact. (Based on similar idea in #4774 )
In terms of units more work is needed - there are more models that don't work well if pi have unit "rad" or "1"; all indicating unit issues e.g.,:
Does not require Modelica Language version 3.7 or updated pi-definition.