Fix import ordering in client auth#2442
Conversation
|
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
There was a problem hiding this comment.
LGTM — trivial two-line import reorder to satisfy simple-import-sort, no behavior change.
Extended reasoning...
Overview
The PR touches a single file, packages/client/src/client/auth.ts, and only reorders one named import (stampErrorBrands) within an existing import statement from @modelcontextprotocol/core-internal. The import list previously had stampErrorBrands between checkResourceAllowed and LATEST_PROTOCOL_VERSION; the PR moves it after resourceUrlFromServerUrl, which matches simple-import-sort's ASCII ordering (uppercase identifiers before lowercase). The PR description explains this is a lint fix for an ordering issue introduced by the combination of #2384 and #2422, both of which passed CI individually.
Security risks
None. No logic, control flow, or API surface changes — the same symbols are imported from the same module; only their textual order changes.
Level of scrutiny
Minimal scrutiny is appropriate. This is a purely mechanical, style-only change with zero runtime impact, equivalent to running the lint autofix. The changeset-bot warning about a missing changeset is fine since a lint-only reorder does not warrant a version bump.
Other factors
The bug hunting system found no issues, there are no outstanding reviewer comments, and the change is exactly what the description claims. This fits squarely in the 'simple, mechanical, obvious' approval category.
Lint autofix:
stampErrorBrandssits out of order in theclient/auth.tsimport list. #2384 and #2422 each passed CI individually, but their combination tripssimple-import-sorton main — any freshly-branched PR now inherits the warning. Two-line reorder, no behavior change.Types of changes
Checklist