fix: type registerTool output from outputSchema#2438
Draft
Grmiade wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: b3cea15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
0739864 to
3e17b26
Compare
3e17b26 to
dbefcb4
Compare
dbefcb4 to
b3cea15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
McpServer.registerToolacceptsoutputSchema, but its callback type only used the input schema. That meant handlers could returnstructuredContentthat did not match the advertised output schema without any TypeScript feedback.McpServeralready validates successful tool output at runtime, so invalidstructuredContentis not returned as a successful result.This typing change catches the same mistakes earlier, while authors are implementing tools, and lets editors and CI enforce the schema contract advertised to clients.
Changes
structuredContentfromoutputSchemawhen one is provided.outputSchemais omitted.inputSchemainference for Standard Schema and raw Zod shape inputs.Validation
pnpm --filter @modelcontextprotocol/server typecheckpnpm --filter @modelcontextprotocol/server lintpnpm --filter @modelcontextprotocol/server test -- test/server/mcp.compat.test.tspnpm --filter @modelcontextprotocol/test-e2e typecheckbuild:all,typecheck:all,lint:all