ci: pin TypeScript workflow actions to immutable SHAs#3907
ci: pin TypeScript workflow actions to immutable SHAs#3907grtninja wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
olaservo
left a comment
There was a problem hiding this comment.
Clean supply-chain security hardening. Both SHAs verified against their respective v6 tags. No workflow logic changes.
This review was assisted by Claude Code.
|
@claude review |
|
Claude finished @cliffhall's task in 1m 11s —— View job PR Review: ci: pin TypeScript workflow actions to immutable SHAs
SummaryThis is a clean, focused supply-chain hardening change. All 7 action references in What Changed
ObservationsCorrect and complete within scope. All action uses in the file are pinned — none were missed. The Most sensitive job is covered. The Other workflow files still use mutable tags. Scanning the repo's remaining workflows reveals unpinned actions in several files:
VerdictLGTM. The change is correct, consistent, and purposefully scoped to the TypeScript workflow as described. No issues found. The follow-up items above are out of scope for this PR but worth tracking. |
Summary
.github/workflows/typescript.ymlto immutable commit SHAsWhy
This workflow handles package publishing and uses
NODE_AUTH_TOKEN, so pinning mutable action tags reduces GitHub Actions supply-chain risk without changing behavior.Validation
git diff --checkpython -c "import pathlib, yaml; p=pathlib.Path(r'.github/workflows/typescript.yml'); yaml.safe_load(p.read_text(encoding='utf-8')); print('yaml_ok', p)"Notes