fix(filesystem): fix quote style and add fileURLToPath regression test#3353
Open
olaservo wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(filesystem): fix quote style and add fileURLToPath regression test#3353olaservo wants to merge 1 commit intomodelcontextprotocol:mainfrom
olaservo wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Follow-up to modelcontextprotocol#3205. Fixes import quote style inconsistency (double to single quotes) and adds a regression test using pathToFileURL() to verify properly-encoded file:// URIs are handled correctly on all platforms. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3205 with two small improvements:
import { fileURLToPath } from "url"to use single quotes, matching the rest of the filepathToFileURL()to verify properly-encodedfile://URIs (the format VS Code sends via MCP roots) are handled correctly on all platformsTest plan
npx vitest run src/filesystem/__tests__/roots-utils.test.ts— all 4 tests pass (3 existing + 1 new)🦉 Generated with Claude Code