chore: Small improvement to progress demo#898
Merged
DaleSeo merged 1 commit intoJun 10, 2026
Merged
Conversation
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
michaelneale
approved these changes
Jun 9, 2026
michaelneale
left a comment
michaelneale
left a comment
Contributor
There was a problem hiding this comment.
Thanks seems reasonable
jrmelsha
added a commit
to UserGeneratedLLC/rmcp-rust-sdk
that referenced
this pull request
Jun 15, 2026
Brings in upstream v1.6.1..266f870 (15 commits): protocol-version negotiation/init-mismatch fixes, input/outputSchema strip+validate (modelcontextprotocol#856/modelcontextprotocol#860), tool-argument errors as tool results (modelcontextprotocol#894), OAuth issuer validation + OIDC application_type + offline_access reauth, roots/ sampling/logging deprecation (SEP-2577), empty-2xx notification handling. Conflict resolutions (fork changes preserved): - handler/server/common.rs: kept both test blocks. Upstream's validate_and_strip / schema_for_input layer composes on top of the fork's ReplaceBoolSchemas normalization in schema_for_type. - handler/server/router/tool.rs: combined upstream's into_tool_argument_error dispatch with the anthropic-ext normalize_call_tool_result post-processing (result kept mutable). Restored .githooks/commit-msg, which upstream modelcontextprotocol#898 deleted incidentally in an unrelated "progress demo" change; the hook gates our conventional- commit workflow and skips merge commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small improvement to progress demo.
Motivation and Context
With the old code, the progress message would only be sent when progressToken and a counter were equal. Otherwise, notifications would not be sent.
How Has This Been Tested?
Manually tested with Postman/Bruno/curl
And with
cargo run --example clients_progress_client -- --transport httpBreaking Changes
No
Types of changes
Checklist