[Server] Make resource subscribe/unsubscribe errors protocol-version-aware (SEP-2164) - #474
Open
chr-hertel wants to merge 2 commits into
Conversation
…aware (SEP-2164) ReadResourceHandler already picked -32602 vs -32002 based on the negotiated revision; ResourceSubscribeHandler and ResourceUnsubscribeHandler still hard-coded the retired -32002 for every client. Bring them in line.
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
August 22, 2026 00:18
chr-hertel
commented
Aug 22, 2026
chr-hertel
commented
Aug 22, 2026
Co-authored-by: Christopher Hertel <mail@christopher-hertel.de>
chr-hertel
added
Server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReadResourceHandlerwas already version-aware for the resource-not-found error code (-32602on2026-07-28+, legacy-32002otherwise), butResourceSubscribeHandlerandResourceUnsubscribeHandlerstill hard-coded the legacy-32002unconditionally.Both handlers now follow the same
RequestContext/ProtocolVersionpatternReadResourceHandleralready uses.Closes #359.
Test plan
phpunitsuite passes (1713 tests)phpstan analyse— no errors